Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor.addAction keybindings #246

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix editor.addAction keybindings #246

merged 1 commit into from
Nov 14, 2023

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Nov 14, 2023 •
edited
Loading

ctrl+K in the demo doesn't work anymore

Not sure about what caused the regression, don't know how it was working

fix #244

@CGNonofr CGNonofr requested a review from kaisalmen November 14, 2023 18:14
@CGNonofr CGNonofr mentioned this pull request Nov 14, 2023
Closed
kaisalmen
kaisalmen approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CGNonofr CGNonofr merged commit e65fbd4 into main Nov 14, 2023
1 check passed
@CGNonofr CGNonofr deleted the fix-addaction-keybindings branch November 14, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monaco actions didn't works with keybinding service override
2 participants
@CGNonofr @kaisalmen